[Webkit-unassigned] [Bug 143212] Web Inspector: Add more ESLint rules that reflect the current state of the code base

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 30 12:23:32 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143212

--- Comment #6 from tobi+bugzilla at basecode.de ---
Comment on attachment 249712
  --> https://bugs.webkit.org/attachment.cgi?id=249712
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249712&action=review

>> Source/WebInspectorUI/.eslintrc:83
>> +        "comma-dangle": 0,
> 
> I don't like using a comma dangle.

The rule is turned off. If you don't want contributors to use trailing commas than we could set "comma-dangle" to "never".

>> Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js:-214
>> -        var currentDisplay = undefined;
> 
> This should be legal.

If you want both to be legal, we could set "no-undef-init" to 0. But keep in mind that `currentDisplay` is undefined by default. There's no need to set it explicitly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150330/bb378dd4/attachment-0002.html>


More information about the webkit-unassigned mailing list