[Webkit-unassigned] [Bug 143212] Web Inspector: Add more ESLint rules that reflect the current state of the code base

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143212

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249712|review?                     |review+, commit-queue+
              Flags|                            |

--- Comment #3 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 249712
  --> https://bugs.webkit.org/attachment.cgi?id=249712
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249712&action=review

> Source/WebInspectorUI/.eslintrc:83
> +        "comma-dangle": 0,

I don't like using a comma dangle.

> Source/WebInspectorUI/UserInterface/Models/SourceCodeLocation.js:-214
> -        var currentDisplay = undefined;

This should be legal.

> Source/WebInspectorUI/UserInterface/Views/ObjectTreePropertyTreeElement.js:-360
> -        var prototypeName = undefined;

Ditto.

> Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:-113
> -        }.bind(this));

This looks like a bug. The function uses this.

> Source/WebInspectorUI/UserInterface/Views/TypeTokenView.js:113
> +        });

Never mind. I see it does not now.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150330/9eb3eaed/attachment-0002.html>