[Webkit-unassigned] [Bug 143216] [GStreamer] More GL shared context fixes

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143216

--- Comment #2 from Martin Robinson <mrobinson at webkit.org> ---
Comment on attachment 249721
  --> https://bugs.webkit.org/attachment.cgi?id=249721
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249721&action=review

Looks good apart from the a naming nit:

> Source/WebCore/platform/graphics/glx/GLContextGLX.h:52
> +    virtual bool isEGLCompliant() const { return false; }

A context isn't really "EGL compliant" it's either an EGL context or something else. I recommend just calling this method "isEGLContext."

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150330/21aaee8b/attachment-0002.html>