[Webkit-unassigned] [Bug 143056] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ResourceResponse

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 29 19:39:38 PDT 2015


--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 249460
  --> https://bugs.webkit.org/attachment.cgi?id=249460

View in context: https://bugs.webkit.org/attachment.cgi?id=249460&action=review

> Source/WebCore/loader/WorkerThreadableLoader.cpp:169
>          delete responseData;

I wonder if we should delete responseData. Because response.copyData() releases own pointer in 163 line. Then *responseData* looks manage the memory.

> Source/WebCore/platform/network/cf/ResourceResponse.h:105
> +    void doPlatformAdopt(std::unique_ptr<CrossThreadResourceResponseData>) { }

One question. Can't we move doPlatformCopyData() and doPlatformAdopt() declarations to ResourceResponseBase.h ?

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150330/074b4e3b/attachment-0002.html>

More information about the webkit-unassigned mailing list