[Webkit-unassigned] [Bug 143169] Web Inspector: TypeProfiler doesn't work on files with ES6 Class Syntax

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 27 19:11:19 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=143169

--- Comment #3 from Saam Barati <saambarati1 at gmail.com> ---
Comment on attachment 249631
  --> https://bugs.webkit.org/attachment.cgi?id=249631
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=249631&action=review

Looks correct to me besides adding the one bit regarding setter/getter methods.

> Source/WebInspectorUI/UserInterface/Models/ScriptSyntaxTree.js:715
> +            };

Like what's done with "Property" below, we should do:
if (result.kind === "get" || result.kind === "set") {
    result.value.isGetterOrSetter = true;
    result.value.getterOrSetterRange = result.key.range;
}

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150328/30c35f0c/attachment-0002.html>


More information about the webkit-unassigned mailing list