[Webkit-unassigned] [Bug 143121] Respect cache-control directives in request

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143121

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249543|review?                     |review+
              Flags|                            |

--- Comment #4 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 249543
  --> https://bugs.webkit.org/attachment.cgi?id=249543
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249543&action=review

r=me

> Source/WebCore/loader/cache/CacheValidation.cpp:155
> +    // See RFC 2616, Section 2.2

We may want to point to the new RFC instead of the deprecated one since we're moving this code :)

> Source/WebCore/loader/cache/CacheValidation.cpp:182
> +static bool isControlCharacter(UChar c)

We could probably mark this one as inline.

> Source/WebCore/loader/cache/CacheValidation.cpp:256
> +            // RFC2616 14.9.1: A no-cache directive with a value is only meaningful for proxy caches.

Ditto about outdated RFC.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:186
> +        auto requestCacheControl = WebCore::parseCacheControlDirectives(request.httpHeaderFields());

I feel that this variable should have 'request' somewhere in the name to avoid confusion with the response ones.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:285
> +    auto cacheControlDirectives = WebCore::parseCacheControlDirectives(originalRequest.httpHeaderFields());

I feel that this variable should have 'request' somewhere in the name to avoid confusion with the response ones.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150327/fdf78fd0/attachment-0002.html>