[Webkit-unassigned] [Bug 143116] Apply blur effect to media control background

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=143116

Brent Fulgham <bfulgham at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249532|review?                     |review+
              Flags|                            |

--- Comment #8 from Brent Fulgham <bfulgham at webkit.org> ---
Comment on attachment 249532
  --> https://bugs.webkit.org/attachment.cgi?id=249532
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249532&action=review

r=me

> Source/WebCore/ChangeLog:10
> +        and the volume slider background not showing the blur effect. I’ll fix those separately.

Bad character in ChangeLog. --> I'll

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1132
> +        ctx.fillStyle = "rgba(140, 140, 140, .68)";

I think we usually write this as "0.68", not ".68"

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1193
> +        ctx.fillStyle = "rgba(140, 140, 140, .68)";

Ditto the leading zero. (.68 -> 0.68)

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150326/ed05f86b/attachment-0002.html>