[Webkit-unassigned] [Bug 121108] Web Inspector gets paused twice when there is an exception in host function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=121108

--- Comment #14 from Mark Lam <mark.lam at apple.com> ---
(In reply to comment #10)
> Hi Joseph and Mark, the new patch has been uploaded. 
> 
> There 3 modifications included:
> (1) Change the Layout test case, since the new implementation (SHA 4cbc701b)
> of "Array.prototype.map" can workaround this bug.
> (2) Correct the coding problem of the old patch.
> (3) Take a missed case into consideration: when VM is unwinding CallFrames
> it will clear the exception temporarily.
> 
> The root cause of this bug is that the exception, thrown form the JS
> callback of host function, will be handled twice. So if the
> 'Debugger::m_currentException' can save the real state of exception of VM,
> we can use it to justify if it's a same exception triggering the debugger in
> second time.

This information about the root cause is helpful in understanding what is being fixed.  It should be included in the ChangeLog.

> Please help to review, thank you very much.

That said, the change in Debugger::exception() that removes the clearing of m_currentException still doesn’t feel right to me.  Let me think about the patch a bit more, and I’ll get back to you with some feedback soon.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150324/c969dfbb/attachment-0002.html>