[Webkit-unassigned] [Bug 137020] [CLoop] - Fix CLoop on the 32-bit Big-Endians

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=137020

--- Comment #9 from Mark Lam <mark.lam at apple.com> ---
Comment on attachment 238528
  --> https://bugs.webkit.org/attachment.cgi?id=238528
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=238528&action=review

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:540
> -    loadp Callee[cfr], targetRegister
> +    if JSVALUE64
> +        loadp Callee[cfr], targetRegister
> +    else
> +        loadp Callee + PayloadOffset[cfr], targetRegister
> +    end

I’m thinking that for 64-bit, PayloadOffset will always be 0 anyway.  Hence, this change should not be needed.  Is that not the case?

> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:550
> -    loadp Callee[cfr], targetRegister
> +    if JSVALUE64
> +        loadp Callee[cfr], targetRegister
> +    else
> +        loadp Callee + PayloadOffset[cfr], targetRegister
> +    end

Ditto.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150324/adba59e8/attachment-0002.html>