[Webkit-unassigned] [Bug 142694] Update empty image canvas tests and fix a related bug

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142694

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249233|review?                     |review+, commit-queue-
              Flags|                            |

--- Comment #17 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 249233
  --> https://bugs.webkit.org/attachment.cgi?id=249233
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249233&action=review

r=me with comments.

> Source/WebCore/ChangeLog:28
> +        (WebCore::ImageLoader::updateFromElement): Fixed casting from CachedResourceHandle<CachedImage> to bool.

Why? CachedResourceHandle has an operator for converting to bool already.

> Source/WebCore/ChangeLog:48
> +        (WebCore::ImageLoader::clearImage):

Unrelated change.

> Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:1756
> +    if (!image->complete() || !cachedImage)

nit: I would find it more logical to reverse the checks to first check that the load has started THEN check that the load is not complete. Please also update the comment above accordingly.

> Source/WebCore/loader/ImageLoader.cpp:238
> +        m_hasPendingLoadEvent = !!newImage;

Unrelated change?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150323/60f197f2/attachment-0002.html>