[Webkit-unassigned] [Bug 140575] Native Bindings Descriptors are Incomplete

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140575

Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #246689|review?, commit-queue?      |review-
              Flags|                            |

--- Comment #11 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 246689
  --> https://bugs.webkit.org/attachment.cgi?id=246689
[PATCH] Proposed Fix

I'm going to r- this.

- Patch is over a month old and probably stale
- I've gotten a better understanding of bindings now, and I don't think the JSAnchoredFunction concept is needed. The bindings did not actually care what the prototype object was, the generated code just ignores the argument...
- Web Inspector worked around this issue in all cases where this was previously an issue. It may happen again some time in the future, but for now we don't actually need the getter / setter function to be called later.
- After discussion with Sam, we should probably look at removing the CustomAccessor special case for Bindings and making it work like a regular Accessor.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150322/6fea46a5/attachment-0002.html>