[Webkit-unassigned] [Bug 142825] Refactor ImageLoader's setting of CachedImage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142825

--- Comment #10 from Yoav Weiss <yoav at yoav.ws> ---
Comment on attachment 249025
  --> https://bugs.webkit.org/attachment.cgi?id=249025
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249025&action=review

>> Source/WebCore/loader/ImageLoader.cpp:139
>> +    if (oldImage) {
> 
> Can this instead be an early return? Is it important to call resetAnimation when m_image is null?

I'm not sure, TBH. Since resetAnimation is called on renderImageResource, which arrives from the element's renderer (so not necessarily null, and not related to m_image), it seems likely that we do need to reset any animations when setting the CachedImage to be null.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150319/f3f5a370/attachment-0002.html>