[Webkit-unassigned] [Bug 142694] Update some canvas tests and fix a related bug with unavailable images

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142694

--- Comment #14 from Darin Adler <darin at apple.com> ---
Comment on attachment 248686
  --> https://bugs.webkit.org/attachment.cgi?id=248686
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248686&action=review

> Source/WebCore/loader/ImageLoader.h:107
> -    bool m_hasPendingBeforeLoadEvent : 1;
> -    bool m_hasPendingLoadEvent : 1;
> -    bool m_hasPendingErrorEvent : 1;
> -    bool m_imageComplete : 1;
> -    bool m_loadManually : 1;
> -    bool m_elementIsProtected : 1;
> +    unsigned m_hasPendingBeforeLoadEvent : 1;
> +    unsigned m_hasPendingLoadEvent : 1;
> +    unsigned m_hasPendingErrorEvent : 1;
> +    unsigned m_imageComplete : 1;
> +    unsigned m_imageUnavailable : 1;
> +    unsigned m_loadManually : 1;
> +    unsigned m_elementIsProtected : 1;

Please don’t make this change. We fixed the style checking script to no longer complain about this, and there is no downside to the old way.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150319/a8171cbf/attachment-0002.html>