[Webkit-unassigned] [Bug 140800] [GTK] Scrollbars look bad with GTK+ 3.16

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=140800

--- Comment #5 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #4)
> Comment on attachment 249028 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=249028&action=review
> 
> r+ with a nit

Thanks for the review.

> I guess we haven't detected it in the bots because they don't have 3.16.
> It's unfortunate to have to depend on dogfeeding to detect this kind of
> regressions.
> 
> > Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281
> > +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect)
> 
> According. Fix also Changelogs

Oops.

> Also perhaps adjustScrollbarRectToMargin?

The method is more generic than that, it's used for scrollbars, but has nothing to do with scrollbars.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150319/a749a1fc/attachment-0002.html>