[Webkit-unassigned] [Bug 140800] [GTK] Scrollbars look bad with GTK+ 3.16

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 19 03:03:12 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=140800

Sergio Villar Senin <svillar at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #249028|review?                     |review+
              Flags|                            |

--- Comment #4 from Sergio Villar Senin <svillar at igalia.com> ---
Comment on attachment 249028
  --> https://bugs.webkit.org/attachment.cgi?id=249028
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=249028&action=review

r+ with a nit

I guess we haven't detected it in the bots because they don't have 3.16. It's unfortunate to have to depend on dogfeeding to detect this kind of regressions.

> Source/WebCore/platform/gtk/ScrollbarThemeGtk.cpp:281
> +static void adjustRectAccoringToMargin(GtkStyleContext* context, GtkStateFlags state, IntRect& rect)

According. Fix also Changelogs

Also perhaps adjustScrollbarRectToMargin?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150319/60f34097/attachment-0002.html>


More information about the webkit-unassigned mailing list