[Webkit-unassigned] [Bug 142778] [EFL] Add OpenWebRTC in jhbuild

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142778

--- Comment #15 from Philippe Normand <pnormand at igalia.com> ---
(In reply to comment #14)
> (In reply to comment #12)
> > Comment on attachment 248835 [details]
> > patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=248835&action=review
> > 
> > > Tools/efl/jhbuild.modules:306
> > > +  <autotools id="libusrsctp" autogen-sh="./bootstrap; ./configure">
> > > +    <branch repo="sctp-refimpl-google" module="trunk/KERN/usrsctp/" revision="r9168"/>
> > > +  </autotools>
> > 
> > Unfortunately jhbuild ignores the revision and always checks out the top of
> > trunk. It isn't safe at all.
> 
> Wow, wtf... The revision attr seems used to indicate a *branch* name if I
> read the JHBuild code correctly. This is wrong in so many undescriptive ways.

Ok I take this back :) Pfeww.

Can you try with revision="9168" ? That should work according to https://git.gnome.org/browse/jhbuild/tree/jhbuild/versioncontrol/svn.py#n234

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150318/273df4ab/attachment-0002.html>