[Webkit-unassigned] [Bug 142476] [OpenWebRTC] RealtimeMediaSourceCenter implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142476

Eric Carlson <eric.carlson at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248833|review?                     |review+
              Flags|                            |

--- Comment #3 from Eric Carlson <eric.carlson at apple.com> ---
Comment on attachment 248833
  --> https://bugs.webkit.org/attachment.cgi?id=248833
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248833&action=review

> Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:67
> +    DEPRECATED_DEFINE_STATIC_LOCAL(RealtimeMediaSourceCenterOwr, center, ());

Nit: is there any reason to not use NeverDestroyed?

> Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:80
> +void RealtimeMediaSourceCenterOwr::validateRequestConstraints(PassRefPtr<MediaStreamCreationClient> prpClient, PassRefPtr<MediaConstraints> prpAudioConstraints, PassRefPtr<MediaConstraints> prpVideoConstraints)

Nit: it would be good to switch from PassRefPtr/RefPtr to Ref before the WebRTC implementation(s) get any bigger. Not necessarily in this patch, but soon.

> Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:146
> +    GList* item;
> +
> +    for (item = sources; item; item = item->next) {

Nit: this isn't needed outside of the loop so you shouldn't need to pre-declare it. Can you use "auto"?

> Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:159
> +        if (mediaType & OWR_MEDIA_TYPE_AUDIO)
> +            sourceType = RealtimeMediaSource::Audio;
> +        else if (mediaType & OWR_MEDIA_TYPE_VIDEO)
> +            sourceType = RealtimeMediaSource::Video;

else ASSERT()

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150317/571984ee/attachment-0002.html>