[Webkit-unassigned] [Bug 118788] [GTK] WebKitDOM objects leaking

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=118788

--- Comment #21 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #20)
> Comment on attachment 248646 [details]
> New patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248646&action=review
> 
> Looks good

Thanks.

> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:73
> > +    }
> 
> I think it's worth also to try to load some external resource and reload it
> multiple times as the code paths are different that starting new loads.

Not easy in this case, but even if the code path is not exactly the same, the global object is detached from frame on reload as well, so there's no difference.

> > Tools/TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:67
> > +    // Test /WebKitDOMNode/dom-cache is an exception, because it's called twice, so
> 
> trice right?

Right.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150317/e59dc86b/attachment-0002.html>