[Webkit-unassigned] [Bug 121108] Web Inspector gets paused twice when there is an exception in host function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 15 00:49:19 PDT 2015


--- Comment #5 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 248504
  --> https://bugs.webkit.org/attachment.cgi?id=248504

View in context: https://bugs.webkit.org/attachment.cgi?id=248504&action=review

This seems fine to me. Mark Lam would be a better reviewer.

> Source/JavaScriptCore/debugger/Debugger.cpp:158
> +    , m_currentException(JSValue())

I don't think this is necessary, since JSValue is a class, the default constructor would get called, and be exactly this.

> Source/JavaScriptCore/debugger/Debugger.cpp:633
> +    if (m_currentException != JSValue() && m_vm->exception() == JSValue()
> +        && !m_hasHandlerForExceptionCallback)

Likewise these comparison to JSValue(). Can they just be "!foo" since JSCJSValue has operator UnspecifiedBoolType?

  if (m_currentException && !m_vm->exception() && !m_hasHandlerForExceptionCallback)
      m_currentException = JSValue();

> Source/JavaScriptCore/debugger/Debugger.cpp:698
> +    if (m_isPaused && m_currentException != JSValue())

Likewise, could this just be "&& m_currentException".

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150315/67b6efae/attachment-0002.html>

More information about the webkit-unassigned mailing list