[Webkit-unassigned] [Bug 118788] [GTK] WebKitDOM objects leaking

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Mar 14 01:56:39 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=118788

Carlos Garcia Campos <cgarcia at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248431|0                           |1
        is obsolete|                            |
 Attachment #248646|                            |review?
              Flags|                            |

--- Comment #19 from Carlos Garcia Campos <cgarcia at igalia.com> ---
Created attachment 248646
  --> https://bugs.webkit.org/attachment.cgi?id=248646&action=review
New patch

Instead of making DOMObjectCacheFrameObserver inherit from DOMWindowProperty, use a helper class DOMWindowObserver used as a member of DOMObjectCacheFrameObserver and created/destroyed on demand to track the document when it's detached form the frame, but also when a new document is created. I've updated the unit test to run 3 times, because when run twice, the first time objects were correctly cleared when the document was detached from frame, but the second time it was the frame destruction what caused the objects to be cleared.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150314/2bd7ce1f/attachment-0002.html>


More information about the webkit-unassigned mailing list