[Webkit-unassigned] [Bug 142677] Stop image from displaying when src attribute is removed or emptied

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142677

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248602|review?                     |review+
              Flags|                            |

--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 248602
  --> https://bugs.webkit.org/attachment.cgi?id=248602
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248602&action=review

r=me % nits.

> Source/WebCore/loader/ImageLoader.cpp:174
> +    if (!attr.isNull() && attr == m_failedLoadURL)

I would have a slight preference for if (!m_failedLoadURL.isEmpty() && m_failedLoadURL == attr), with a comment saying something like "Do not to reload an URL we already failed to load".

> LayoutTests/fast/dom/HTMLImageElement/image-empty-src-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-src.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-empty-srcset.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-src.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset-expected.html:3
> +<div id=result>75</div>

I don't think we need this, do we?

> LayoutTests/fast/dom/HTMLImageElement/image-remove-srcset.html:9
> +        result.innerHTML = img.width;

I don't think we need this, do we?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150313/657ec9a5/attachment-0002.html>