[Webkit-unassigned] [Bug 17022] Add APNG support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=17022

--- Comment #37 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #36)
> Created attachment 248452 [details]
> v08_apng_webkit.patch
> 
> OK, most of the suggestions implemented.

Thanks!

> Few other cases:
> 
> > Shouldn't we initialize dest in this case? *dest = 0;
> 
> No, this is by design. Applying top layer with alpha = 0 over the background
> layer means nothing will change, and we can bailout early.

Ok.

> > Could this be an IntSize?
> > And this IntPoint?
> 
> I would really like to keep them unsigned, makes it easier to work with
> libpng.

Ah, I see.

> > I wonder if we could move m_curFrame out of the #ifdef, but it will always be 0 for non APNG. 
> > This way we can avoid a lof of #ifdefs in the code I think.
> 
> Yes, it's always 0 for non APNG, but I would like to keep all new code
> inside #if ENABLE(APNG) as requested in comment 8.

Well, I disagree, as long as it builds with and without the APNG enabled, and the code not protected by the ifdefs doesn't affect the performance, I think it's better to reduce the amount of ifdefs to improve the code readability and maintainability.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150312/d7d956a4/attachment-0002.html>