[Webkit-unassigned] [Bug 140722] Simplify CachedImage clients to avoid overriding both or either only imageChanged or notifyFinished

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 15:51:18 PDT 2015


Andreas Kling <akling at apple.com> changed:

           What    |Removed                     |Added
                 CC|                            |akling at apple.com

--- Comment #20 from Andreas Kling <akling at apple.com> ---
This caused various problems with ImageLoaders getting stuck with m_hasPendingLoadEvent=true, which prevents the garbage collector from deleting these elements.

I'm rolling the change out since it wasn't clearly fixing a bug in the first place.

I suspect that the main cause of problems is that FrameLoader::stopAllLoaders(), which is called on navigation, ends up causing pending CachedResources to become cancelled, but cancelling a CachedResources fires notifyFinished(), not imageChanged().

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150311/d8243fa6/attachment-0002.html>

More information about the webkit-unassigned mailing list