[Webkit-unassigned] [Bug 142599] New: Web Inspector: Split ConsoleMessageImpl into the View and the Model

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 15:50:26 PDT 2015


            Bug ID: 142599
           Summary: Web Inspector: Split ConsoleMessageImpl into the View
                    and the Model
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: All
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: nvasilyev at apple.com
                CC: graouts at webkit.org, joepeck at webkit.org,
                    jonowells at apple.com, mattbaker at apple.com,
                    nvasilyev at apple.com, timothy at apple.com,
                    webkit-bug-importer at group.apple.com

This issue is for refactoring only, it has no UI changes.

1. Merge ConsoleMessage and ConsoleMessageImpl.

WebInspector.ConsoleMessageImpl inherits from WebInspector.ConsoleMessage. However, WebInspector.ConsoleMessageImpl gets instantiated only by WebInspector.ConsoleMessage.create, which makes the two tightly coupled and defeats the purpose of inheritance.

ConsoleMessage isn’t used by anything other than ConsoleMessageImpl, so there is no point of keeping them both – they should be merged.

2. Split ConsoleMessage(Impl) into the View and the Model.

Model will hold the data and some logic but no DOM operations, all DOM operations will go to the view.

I believe, it should be possible to have more than one view for a single model, although, I don’t yet know a use case for that.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150311/22b2cc66/attachment-0002.html>

More information about the webkit-unassigned mailing list