[Webkit-unassigned] [Bug 17022] Add APNG support

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 11 14:44:46 PDT 2015


Max Stepin <maxstepin at yahoo.com> changed:

           What    |Removed                     |Added
 Attachment #236444|0                           |1
        is obsolete|                            |
 Attachment #236444|review?                     |
              Flags|                            |

--- Comment #36 from Max Stepin <maxstepin at yahoo.com> ---
Created attachment 248452
  --> https://bugs.webkit.org/attachment.cgi?id=248452&action=review

OK, most of the suggestions implemented.

Few other cases:

> Shouldn't we initialize dest in this case? *dest = 0;

No, this is by design. Applying top layer with alpha = 0 over the background layer means nothing will change, and we can bailout early.

> Could this be an IntSize?
> And this IntPoint?

I would really like to keep them unsigned, makes it easier to work with libpng.

> I wonder if we could move m_curFrame out of the #ifdef, but it will always be 0 for non APNG. 
> This way we can avoid a lof of #ifdefs in the code I think.

Yes, it's always 0 for non APNG, but I would like to keep all new code inside #if ENABLE(APNG) as requested in comment 8.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150311/4761a02a/attachment-0002.html>

More information about the webkit-unassigned mailing list