[Webkit-unassigned] [Bug 142551] Slew of minor edits to media controls on OSX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142551

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #248380|review?                     |review+
              Flags|                            |

--- Comment #11 from Darin Adler <darin at apple.com> ---
Comment on attachment 248380
  --> https://bugs.webkit.org/attachment.cgi?id=248380
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248380&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:578
> +        this.updateProgress(event.type == 'canplay');

Are you sure this is exactly what we want? What if this is called again later for another event? It would be strange to call updateProgress(false) then.

Also, I suggest using === instead of ==.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150311/0ec56980/attachment-0002.html>