[Webkit-unassigned] [Bug 126688] [GTK] Add an option to enable MiniBrowser for non developer builds and always install it

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 10 11:01:53 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=126688

--- Comment #7 from Zan Dobersek <zan at falconsigh.net> ---
Comment on attachment 248329
  --> https://bugs.webkit.org/attachment.cgi?id=248329
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=248329&action=review

> Tools/MiniBrowser/gtk/CMakeLists.txt:-48
> -add_definitions(-DWEBKIT_EXEC_PATH="${CMAKE_RUNTIME_OUTPUT_DIRECTORY}")

Is this not needed anymore?

> Tools/MiniBrowser/gtk/main.c:259
> +#if defined(DEVELOPMENT_BUILD)

Where is DEVELOPMENT_BUILD defined? should this also check that DEVELOPMENT_BUILD is defined to a non-null value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150310/49fabad7/attachment-0002.html>


More information about the webkit-unassigned mailing list