[Webkit-unassigned] [Bug 141692] Web Inspector: Styles sidebar editing with incomplete property looks poor in UI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=141692

--- Comment #13 from Joseph Pecoraro <joepeck at webkit.org> ---
(In reply to comment #11)
> I'm still not happy with my patch. What I really want to do is the following:
> 
> - Listen on onLineChange and onPaste
> - Parse the line and add missing new line characters, colons and semi-colons.
> 
> A parser should be able to convert:
> - key: value => key: value;\n
> - key; => key:;\n
> - /* key:value; key2:value2 */ => /* key: value; */\n/* key2: value2; */\n
> - key:value /* key: value; */ => key: value; /* key: value; */

That seems reasonable to me. I like the idea of splitting up the comments.


> Questions:
> - Where can I listen on "onLineChange" and "onPaste"? _reset doesn't seem to
> be the correct place. It's not called onLineChange.

I don't think CodeMirror has "onLineChange" it has more generic change events, which we have registered for:
http://codemirror.net/doc/manual.html#events

    this._codeMirror.on("change", this._contentChanged.bind(this));

I don't remember off hand, but I would guess that pastes trigger a change as well.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150310/df65bb55/attachment-0002.html>