[Webkit-unassigned] [Bug 142498] [GTK] Add a configure option to build with OpenGL ES 2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142498

--- Comment #11 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #10)
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=248262&action=review
> 
> > Source/cmake/OptionsGTK.cmake:94
> > +        # FIXME: Should we search for cairo-glesv2 instead of cairo-gl in this case?
> 
> Yeah, this FIXME looks to have the correct suggestion. We probably need to
> pass an argument to FindCairoGL.
> 
> > Source/cmake/OptionsGTK.cmake:329
> > +if ((OPENGL_FOUND OR OPENGLES2_FOUND) AND (GLX_FOUND OR EGL_FOUND))
> 
> I think the OPENGES2 + GLX combination is still bogus. :)

Yes, it is, but it simply can't happen if I understood correctly how cmake works. GLX_FOUND is set by find_package(OpenGL), that is only called when OPENGLES2 option is not present, so it's not possible to have both.

> One easy way to
> fix it is to error out early if EGL isn't found.

That's what the patch does.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150309/535d11ea/attachment-0002.html>