[Webkit-unassigned] [Bug 64861] Need support for :dir() pseudo-class
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Mar 7 10:53:04 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=64861
Sylvain Galineau <galineau at adobe.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #248025|0 |1
is obsolete| |
--- Comment #9 from Sylvain Galineau <galineau at adobe.com> ---
Created attachment 248159
--> https://bugs.webkit.org/attachment.cgi?id=248159&action=review
Updated WIP
All stylistic fixes applied. A few comments below.
>> Source/WebCore/css/SelectorChecker.cpp:1014
>> + {
>This bracket should be on the previous line.
I matched the style of all the other case statements in the function e.g. PseudoClassLang, PseudoClassScope...; do they all need fixing?
>> Source/WebCore/dom/Element.cpp:2424
>> + return LTR; // Must ASSERT we don't get here
>ASSERT_NOT_REACHED()
This was worth trying because it does get reached. Will look into this more...Commented out for now.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150307/76db8434/attachment-0002.html>
More information about the webkit-unassigned
mailing list