[Webkit-unassigned] [Bug 142392] Move dispatch_data use behind NetworkCache::Data abstraction
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 6 08:23:45 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=142392
Anders Carlsson <andersca at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #248060|review? |review+
Flags| |
--- Comment #5 from Anders Carlsson <andersca at apple.com> ---
Comment on attachment 248060
--> https://bugs.webkit.org/attachment.cgi?id=248060
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=248060&action=review
> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:113
> + void apply(std::function<bool (const uint8_t*, size_t)>&&) const;
I think the function can be const& here.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheDataCocoa.mm:70
> + if (!m_size)
> + return;
It's a little weird that calling apply on an empty Data results in nothing happening.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:264
> + Vector<uint8_t, 4096> filler(dataOffset - headerData.size(), 0);
I'd use an std::array here instead.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150306/fdd374c2/attachment-0002.html>
More information about the webkit-unassigned
mailing list