[Webkit-unassigned] [Bug 142389] New: Deprecate willDestroyFrame in WKBundlePageLoaderClient

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142389

            Bug ID: 142389
           Summary: Deprecate willDestroyFrame in WKBundlePageLoaderClient
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebKit2
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: cgarcia at igalia.com
                CC: andersca at apple.com, darin at apple.com, sam at webkit.org

I added willDestroyFrame in r154540 but I realized recently (see bug #141641) that it has never actually worked :-( Adding the callback to WKBundlePageLoaderClient was the first mistake, since frames are handled by WebProcess and DidDestroyFrame message is indeed a WebProcessProxy not a WebPageProxyProxy one. Second mistake was calling the callback from WebFrameLoaderClient::frameLoaderDestroyed(), since at that point the frame has already been detached from the page and so WebFrame::page() always returns nullptr. So this in fact dead code. And since r180211 nobody is using it. 
My first idea was to deprecate the method and remove the dead code, but since there aren't any new versions of WKBundlePageLoaderClient, and I guess nobody apart from WebKit internally is using it, maybe we can just remove it?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150306/92271a59/attachment-0002.html>