[Webkit-unassigned] [Bug 131162] [EFL][WK2] Crash when "Download Linked File" from MiniBrowser context menu is clicked

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 5 04:23:21 PST 2015


--- Comment #13 from Lukasz Bialek <l.bialek at samsung.com> ---

New patch uploaded. 

> Typo: DownloadMaager -> DownloadManager


> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_download_job.cpp:-44
> > -class EWK2DownloadJobTest : public EWK2UnitTestBase {
> Why should we remove this unit test ? I think we need to modify this unit
> test based on this change.

Tests are modified and enabled. They pass.

> > Source/WebKit2/UIProcess/efl/DownloadManagerEfl.cpp:164
> > +    RefPtr<EwkDownloadJob> ewkDownload = EwkDownloadJob::create(download);
> I think EwkDownloadJob::create() is not necessary. We can make an instance
> with new EwkDownloadJob if we move its constructor from private to public.

Unfortunately, when I tried to convert it to unique_ptr approach, I encountered a problem with HashMap add operation ("use of deleted function 'std::unique_ptr<_Tp, _Dp>& std::unique_ptr<_Tp, _Dp>::operator=(...)". I would leave it for now because it will need some further investigation about HashMap and this problem is not connected with subject of this patch. It can be easily fixed in separete bug.

Best regards,
Lukasz Bialek

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150305/70a3ff77/attachment-0002.html>

More information about the webkit-unassigned mailing list