[Webkit-unassigned] [Bug 142279] Factor platform I/O out from NetworkCacheStorage

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142279

Chris Dumez <cdumez at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247865|review?                     |review+
              Flags|                            |

--- Comment #6 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 247865
  --> https://bugs.webkit.org/attachment.cgi?id=247865
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247865&action=review

r=me % nits.

> Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp:126
> +        body = NetworkCacheData(reinterpret_cast<const uint8_t*>(responseData->data()), responseData->size());

Doesn't this work?
body = { reinterpret_cast<const uint8_t*>(responseData->data()), responseData->size() };

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:43
> +template<typename T> class DispatchPtr {

Feels like this could be in its own file.

> Source/WebKit2/NetworkProcess/cache/NetworkCacheData.h:97
> +    NetworkCacheData() { }

NetworkCacheData() = default; ?

> Source/WebKit2/NetworkProcess/cache/NetworkCacheIOChannel.h:49
> +    NetworkCacheIOChannel(int fd);

nit: explicit

> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:211
> +    data = NetworkCacheData { headerData };

Do we need to explicitly specific NetworkCacheData ?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150304/1ae7fa11/attachment-0002.html>