[Webkit-unassigned] [Bug 142284] [Win] Missing dependency checking in WebCore/DerivedSources.make for WebCore/css/CSSValueKeywords.in

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142284

--- Comment #2 from Brent Fulgham <bfulgham at webkit.org> ---
(In reply to comment #1)
> - I’m not sure how to fix WinCairo other than to list its
> FeatureDefinesCairo.props file as well.  (Probably okay.)

Usually the two are kept in sync, so it might be reasonable to start off with just the FeatureDefines.props. Per might have ideas on how to make this better as well. But for now, I suggest we just add FeatureDefines.props and see how substantially this improves things.

> - Are we allowed to reference files in WebKitLibraries from Source/WebCore?
> Seems like bad form to reference files outside of Source/WebCore, but maybe
> Windows builds in production with the entire svn directory???

No, but FeatureDefines.props is always available in the location $WEBKIT_LIBRARIES/tools/vsprops/FeatureDefines.props, so we should be able to add this rule.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150304/0e30df8b/attachment-0002.html>