[Webkit-unassigned] [Bug 142284] [Win] Missing dependency checking in WebCore/DerivedSources.make for WebCore/css/CSSValueKeywords.in

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142284

--- Comment #1 from Brent Fulgham <bfulgham at webkit.org> ---
David Kilzer suggested a fix:

A clean build should fix this, but something like this (UNTESTED) might also fix it:

diff --git a/Source/WebCore/DerivedSources.make b/Source/WebCore/DerivedSources.make
index d91ff21..f782eb5 100644
--- a/Source/WebCore/DerivedSources.make
+++ b/Source/WebCore/DerivedSources.make
@@ -717,8 +717,12 @@ ifeq ($(shell $(CC) -std=gnu++11 -x c++ -E -P -dM $(SDK_FLAGS) $(FRAMEWORK_FLAGS
 endif

 ifeq ($(PLATFORM_FEATURE_DEFINES),)
+ifeq ($(OS),Windows*)
+PLATFORM_FEATURE_DEFINES = ../../WebKitLibraries/win/tools/vsprops/FeatureDefines.props
+else
 PLATFORM_FEATURE_DEFINES = Configurations/FeatureDefines.xcconfig
 endif
+endif

 ifeq ($(WTF_PLATFORM_IOS), 1)
 ADDITIONAL_BINDING_IDLS =

Why I didn’t land this as a build fix:

- I’m not sure how to fix WinCairo other than to list its FeatureDefinesCairo.props file as well.  (Probably okay.)
- Are we allowed to reference files in WebKitLibraries from Source/WebCore? Seems like bad form to reference files outside of Source/WebCore, but maybe Windows builds in production with the entire svn directory???

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150304/fd9c71d2/attachment-0002.html>