[Webkit-unassigned] [Bug 142224] New: BitStack::top() should calculate an index instead of always using m_words.last()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142224

            Bug ID: 142224
           Summary: BitStack::top() should calculate an index instead of
                    always using m_words.last()
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Layout and Rendering
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: wjmaclean at chromium.org

BitStack::push() calculates an index based on m_size to determine where the new entry is supposed to go.

However, BitStack::top() always looks up the bit value using m_words.last(), which can be wrong if popping elements has caused m_size to point into a word other than the last one (simple test: push 'true' 33 times, then pop() once and call top() ... it will read 'false'.)

BitStack::top() should instead calculate an index the same as push().

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150303/9335e19d/attachment-0002.html>