[Webkit-unassigned] [Bug 142215] Include key to NetworkCacheStorage::Entry
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Mar 3 09:39:38 PST 2015
https://bugs.webkit.org/show_bug.cgi?id=142215
Chris Dumez <cdumez at apple.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #247757|review? |review+
Flags| |
--- Comment #3 from Chris Dumez <cdumez at apple.com> ---
Comment on attachment 247757
--> https://bugs.webkit.org/attachment.cgi?id=247757
patch
View in context: https://bugs.webkit.org/attachment.cgi?id=247757&action=review
r=me with a question.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:304
> + return std::unique_ptr<NetworkCacheStorage::Entry>(new NetworkCacheStorage::Entry {
Why are you moving away from std::make_unique<>() in this patch? I personally prefer std::make_unique<>() than explicitly calling new.
> Source/WebKit2/NetworkProcess/cache/NetworkCacheStorageCocoa.mm:458
> + m_pendingReadOperationsByPriority[priority].append(new ReadOperation { key, WTF::move(completionHandler) });
ditto here and a couple of other places.
--
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150303/a5bdaa99/attachment-0002.html>
More information about the webkit-unassigned
mailing list