[Webkit-unassigned] [Bug 142189] New: The InspectorTimelineAgent should not be allowed to start twice.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142189

            Bug ID: 142189
           Summary: The InspectorTimelineAgent should not be allowed to
                    start twice.
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Web Inspector
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: mark.lam at apple.com
                CC: graouts at webkit.org, joepeck at webkit.org,
                    jonowells at apple.com, mattbaker at apple.com,
                    nvasilyev at apple.com, timothy at apple.com,
                    webkit-bug-importer at group.apple.com

InspectorTimelineAgent::internalStop() already checks for redundant calls to it in case the InspectorTimelineAgent is already disabled.  Similarly, InspectorTimelineAgent::internalStart() should check if the InspectorTimelineAgent is already enabled before proceeding to do work to enable it.   Though wasteful, it is legal for clients of the InspectorTimelineAgent to invoke start on it more than once.  Hence, this check is needed.

This check fixes the debug assertion failure when running the inspector/timeline/debugger-paused-while-recording.html test.  The test can now be unskipped.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/41d426d5/attachment-0002.html>