[Webkit-unassigned] [Bug 142138] Update inline media element apperance

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142138

Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247699|review?                     |review+
              Flags|                            |

--- Comment #15 from Dean Jackson <dino at apple.com> ---
Comment on attachment 247699
  --> https://bugs.webkit.org/attachment.cgi?id=247699
patch part 2

View in context: https://bugs.webkit.org/attachment.cgi?id=247699&action=review

r+, but I think this should be in a separate bug.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1023
> +        width = this.controls.timeline.offsetWidth;
> +        height = this.controls.timeline.offsetHeight;
> +        
> +        ctx.save();
> +        ctx.scale(dpr, dpr);
> +        ctx.clearRect(0, 0, width, height);

i'd do
width /= dpr;
height /= dpr;

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.js:1088
> +        width = this.controls.volume.offsetWidth;
> +        height = this.controls.volume.offsetHeight;
> +        
> +        ctx.save();
> +        ctx.scale(dpr, dpr);
> +        ctx.clearRect(0, 0, width, height);

Same here.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/c8375df9/attachment-0002.html>