[Webkit-unassigned] [Bug 142138] Update inline media element apperance

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 10:53:00 PST 2015


Dean Jackson <dino at apple.com> changed:

           What    |Removed                     |Added
 Attachment #247654|review?                     |review+
              Flags|                            |

--- Comment #12 from Dean Jackson <dino at apple.com> ---
Comment on attachment 247654
  --> https://bugs.webkit.org/attachment.cgi?id=247654

View in context: https://bugs.webkit.org/attachment.cgi?id=247654&action=review

> Source/WebCore/ChangeLog:11
> +        Volume and timeline sliders will be drawn in a separate patch via 2d canvases.
> +        * Modules/mediacontrols/mediaControlsApple.css:

Nit. Separate these with a blank line.

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:170
> +    -webkit-transform: rotate(-90deg) translateY(-4px) translateX(-5px);

You should be able to just say translate(-5px, -4px)

> LayoutTests/platform/mac/TestExpectations:1288
> +# Skip media control tests until new controls are finalized
> +webkit.org/b/142142 media/video-no-audio.html [ Skip ]

This is a bit scary.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/295cbf05/attachment-0002.html>

More information about the webkit-unassigned mailing list