[Webkit-unassigned] [Bug 142177] New: Rename SOFT_LINK_{CONSTANT, FUNCTION}_{HEADER, SOURCE} to SOFT_LINK_{CONSTANT, FUNCTION}_FOR_{HEADER, SOURCE}

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142177

            Bug ID: 142177
           Summary: Rename SOFT_LINK_{CONSTANT,FUNCTION}_{HEADER,SOURCE}
                    to SOFT_LINK_{CONSTANT,FUNCTION}_FOR_{HEADER,SOURCE}
    Classification: Unclassified
           Product: WebKit
           Version: 528+ (Nightly build)
          Hardware: Unspecified
                OS: Unspecified
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: WebCore Misc.
          Assignee: webkit-unassigned at lists.webkit.org
          Reporter: ddkilzer at webkit.org
                CC: achristensen at apple.com, ap at webkit.org,
                    bfulgham at webkit.org
            Blocks: 141625

In Bug 141816 Comment #17, Alexey suggests renaming the SOFT_LINK macros to include a preposition so they're more readable.

After leaving this code for a few days and coming back, I'm inclined to agree:

SOFT_LINK_{CONSTANT,FUNCTION}_HEADER() => SOFT_LINK_{CONSTANT,FUNCTION}_FOR_HEADER()
SOFT_LINK_{CONSTANT,FUNCTION}_SOURCE() => SOFT_LINK_{CONSTANT,FUNCTION}_FOR_SOURCE()

In bug 141816, Alexey suggested "CPP" instead of "SOURCE", although I find "CPP" more ambiguous:  "C Pre-Processor", which would be the same as "HEADER" vs. "C-Plus-Plus [Source]".

I suppose if we used "CPP" instead of "SOURCE", we should use "H" instead of "HEADER" to be consistent, but that doesn't seem like an improvement either.

Will follow up with Alexey in person.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/dc8aa207/attachment-0002.html>