[Webkit-unassigned] [Bug 142164] [SOUP] Use SoupMessage::starting instead of SoupSession::request-started

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 2 06:19:48 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=142164

--- Comment #3 from Carlos Garcia Campos <cgarcia at igalia.com> ---
(In reply to comment #2)
> Comment on attachment 247662 [details]
> Patch

Thanks!

> View in context:
> https://bugs.webkit.org/attachment.cgi?id=247662&action=review
> 
> Makes sense. Any test that could start have started to pass due to this
> change?

I've tried all webtiming tests in TestExpectations before the patch and all of them passed, so . . . Anyway, this only affects disk cached resources, so I guess that's not the case of any test.

> > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:119
> >  #endif
> 
> Pretty unfortunate to have the WebTiming stuff here. Hopefully we could
> remove it with the starting signal at some point.

Yes, indeed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/9be50944/attachment-0002.html>


More information about the webkit-unassigned mailing list