[Webkit-unassigned] [Bug 142143] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=142143

Gyuyoung Kim <gyuyoung.kim at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247625|                            |commit-queue+
              Flags|                            |

--- Comment #4 from Gyuyoung Kim <gyuyoung.kim at webkit.org> ---
Comment on attachment 247625
  --> https://bugs.webkit.org/attachment.cgi?id=247625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247625&action=review

cq=me.

>> Source/WebCore/platform/ScrollAnimator.h:62
>> +    explicit ScrollAnimator(ScrollableArea&);
> 
> It’s not so great that now a client can now accidentally create a ScrollAnimator directly with make_unique, when it should be calling ScrollAnimator::create.

I also think like that. However, now we don't have best solution yet. In this case, lambdas looks not great benefit. When we have better solution, let's fix it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150302/35e6d77c/attachment-0002.html>