[Webkit-unassigned] [Bug 142143] Use std::unique_ptr instead of PassOwnPtr|OwnPtr for ScrollAnimator

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Mar 1 11:04:02 PST 2015


https://bugs.webkit.org/show_bug.cgi?id=142143

Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #247625|review?                     |review+
              Flags|                            |

--- Comment #3 from Darin Adler <darin at apple.com> ---
Comment on attachment 247625
  --> https://bugs.webkit.org/attachment.cgi?id=247625
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=247625&action=review

> Source/WebCore/platform/ScrollAnimator.h:62
> +    explicit ScrollAnimator(ScrollableArea&);

It’s not so great that now a client can now accidentally create a ScrollAnimator directly with make_unique, when it should be calling ScrollAnimator::create.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150301/9660316d/attachment-0002.html>


More information about the webkit-unassigned mailing list