[Webkit-unassigned] [Bug 145885] Web Inspector: When autocompleting, pressing tab twice shouldn't insert a tab character

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=145885

Timothy Hatcher <timothy at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #255785|review?                     |review-
              Flags|                            |

--- Comment #11 from Timothy Hatcher <timothy at apple.com> ---
Comment on attachment 255785
  --> https://bugs.webkit.org/attachment.cgi?id=255785
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255785&action=review

> Source/WebInspectorUI/ChangeLog:11
> +        (WebInspector.ConsolePrompt.prototype._handleOnKeyEvent): Pressing any key other than tab will remove
> +        the "<- no results" if it exists.

I don't think this is needed. You could just call InspectorFrontendHost.beep() if tab is pressed and does nothing, that is more inline with what happens on Mac for invalid keypresses.

> Source/WebInspectorUI/UserInterface/Views/ConsolePrompt.js:194
> +        if (trimmedLine.endsWith(".")) {
> +            this._completionController._completeAtCurrentPosition(true);
> +            return;
> +        }

This is using private API and is making assumptions (endsWith(".")) about the completion controller that might not always be correct.

It would be best to have a public API like "completeAtCurrentPositionIfNeeded".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150630/afd3ed4f/attachment.html>