[Webkit-unassigned] [Bug 146450] [WinCairo] Compile error, WebEditorClient::didApplyStyle() should not have any parameters.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146450

--- Comment #3 from peavo at outlook.com ---
(In reply to comment #2)
> Comment on attachment 255815 [details]
> Patch
> 
> LGTM, r=me. Could you add an override keyword before 
> landing to avoid possible bugs in the future here?
> 
> ( Just note: This code was introduced in bug146379 -
> https://trac.webkit.org/changeset/186086 )

Thanks for reviewing :)

Yes, I can add the override keyword, but I seem to remember there was an agreement not to add the override keyword when overriding pure virtual methods?

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150630/a176dc1b/attachment.html>