[Webkit-unassigned] [Bug 146178] REGRESSION(r184000): Web Inspector: Multiline CSS in Styles Sidebar is marked as invalid

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 14:07:36 PDT 2015


--- Comment #19 from Joseph Pecoraro <joepeck at webkit.org> ---
Comment on attachment 255656
  --> https://bugs.webkit.org/attachment.cgi?id=255656
Fixed the issue

View in context: https://bugs.webkit.org/attachment.cgi?id=255656&action=review

> Source/WebInspectorUI/Tools/PrettyPrinting/css-rule-tests/add-whitespace-between-values.css:3
> +border: 1px
> +  solid
> +  black;

Seems it would be more useful to test this without leading spaces on the subsequent lines.
Likewise we should have a test for multiple rules, even multiple rules on the same line

> Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js:483
> +        // There should be no extra newlines after css-rules in the sidebar.  They should always display on one line.

Style: Just a single space after a period.

This comment is somewhat misleading and contains superfluous text. How about:

    // Each property should be formatted to one line each with no extra newlines.

You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150626/7f940fcc/attachment.html>

More information about the webkit-unassigned mailing list