[Webkit-unassigned] [Bug 146242] WinLauncher fails to download files.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 26 05:43:48 PDT 2015


https://bugs.webkit.org/show_bug.cgi?id=146242

--- Comment #18 from peavo at outlook.com ---
(In reply to comment #16)
> Comment on attachment 255512 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=255512&action=review
> 
> Sorry, I'm not doing a very good job reviewing this.  This needs one more
> iteration, and it's my fault.
> 
> > Tools/WinLauncher/WebDownloadDelegate.cpp:32
> > +    : m_refCount(0)
> 
> Ok, sorry about my earlier comment.  This should indeed be 1.  And use
> _com_ptr_t::Attach after making a new WebDownloadDelegate.

No worries :) Updated patch.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150626/bc5b85c4/attachment.html>


More information about the webkit-unassigned mailing list