[Webkit-unassigned] [Bug 146300] AX: AccessibilityObject focus event that doesn't cause a selection change can leave m_isSynchronizingSelection set to true

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=146300

--- Comment #3 from chris fleizach <cfleizach at apple.com> ---
Comment on attachment 255531
  --> https://bugs.webkit.org/attachment.cgi?id=255531
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=255531&action=review

> LayoutTests/ChangeLog:3
> +        Bug 146300 AX: AccessibilityObject focus event that doesn't cause a selection 

"focus events that don't cause a"

> Source/WebCore/accessibility/AccessibilityRenderObject.cpp:1513
> +    AXObjectCache* cache = renderObject.axObjectCache();

It looks like this method might be better off taking a point to the axobject cache

> Source/WebCore/accessibility/mac/AXObjectCacheMac.mm:337
> +        [rootWebArea()->wrapper() accessibilityPostedNotification:NSAccessibilityFocusedUIElementChangedNotification userInfo:nil];

since this looks like it's only for testing, i would change the name to something like "AXFocusedChanged" so that when checking this in the test it will be clear what the value should be, and
will also let other platforms follow suit

-- 
You are receiving this mail because:
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.webkit.org/pipermail/webkit-unassigned/attachments/20150625/3b5436b2/attachment.html>